Chore(ClipboardCopy): add tooltip to play icon#11583
Chore(ClipboardCopy): add tooltip to play icon#11583nicolethoen merged 3 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11583.surge.sh A11y report: https://patternfly-react-pr-11583-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
In addition to the file comments below:
- The issue linked in your original comment should point to #11385
- The Codeblock examples just need a similar update
- Can you update the original commit message and PR title to a
chorerather than a feature?
| </ClipboardCopy> | ||
| ); | ||
| export const ClipboardCopyInlineCompactWithAdditionalAction: React.FunctionComponent = () => { | ||
| const [showSuccessContent, setShowSuccessContent] = React.useState(false); |
There was a problem hiding this comment.
Slight nitpick, but maybe [isRunning, setIsRunning] for the state so that it's aligned closer to the intent of the state.
| variant="inline-compact" | ||
| additionalActions={ | ||
| <ClipboardCopyAction> | ||
| <Tooltip aria="none" aria-live="polite" content={showSuccessContent ? doneRunText : runText}> |
There was a problem hiding this comment.
Depends on the intent of the example when originally added, but for now let's add the onTooltipHidden callback to set the state back to false. That way when the tooltip disappears and you retrigger it, it'll say "Run in web terminal" again rather than staying as "Running in web terminal".
There was a problem hiding this comment.
Right, will make the necessary changes.
Mash707
force-pushed
the
adding-tooltip-to-playicon
branch
from
c4e2cd7 to
d1d9604
Compare
Mash707
changed the title
|
If possible, Can I get details regarding why |
Mash707
force-pushed
the
adding-tooltip-to-playicon
branch
from
14e8615 to
cc05938
Compare
Mash707
force-pushed
the
adding-tooltip-to-playicon
branch
from
cc05938 to
14c0bb3
Compare
Nevermind had some rebasing issues. |
4 participants
Closes #11385